Correct pods dependency to allow Text to render #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Good catch, @mudetroit! So the issue is the Thanks! Mergin’… |
| @@ -1,3 +1,4 @@ | |||
| source 'https://github.com/CocoaPods/Specs.git' | |||
|
|
|||
| pod 'React', :git => 'https://github.com/facebook/react-native' | |||
| pod 'React' | |||
There was a problem hiding this comment.
I’m not sure we also needed to change sourcing the React CocoaPod, but that’s okay for now. Pulling the podspec directly from the repo was an attempt to fix the problem that this PR actually fixes. 👍
There was a problem hiding this comment.
I actually originally left it there, but it was yelling at me. When I simplified it down to just React it worked 😕 ... end of the day seemed like working was an improvement
andrewsardone
added a commit
that referenced
this pull request
Mar 31, 2015
Correct pods dependency to allow Text to render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relevant change that fixes the issue is in the Podfile. Probably need to include some other libraries to support debugging and such.